fix(import-media): Display success/total count even if all files fail to import #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
saroshaga
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2005
Description
In the
vip import mediacommand, when all files in the archive fails/errors while importing, the import does not show the success/total count in the end. This is because of a bug in the null-check filter where the case offilesProcessed = 0is being consumed by the null check.Pull request checklist
Steps to Test
npm run buildnode ./dist/bin/vip import media @<app>.<env> https://getsamplefiles.com/download/zip/sample-1.ziptwice. In the second run, all the files should fail to import as they are already imported. When that happens, make sure that theImported Files: 0/4 - 0% ✓line is present in the output.