Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount vip-config directly in wp #1467

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

pschoffer
Copy link
Contributor

@pschoffer pschoffer commented Jul 25, 2023

Description

We load vip-config.php currently from /wp/wp-content/vip-config/vip-config.php however in live environments the vip-config folders is mapped directly to /wp/vip-config (not under wp-content).

We should migrate the location to more closely match the prod environment. That way we can support other files too such as client-sunrise.php which is loaded from /wp/vip-config/client-sunrise.php

This is the second part of the change where we change mount location

This should only be merged AFTER Automattic/vip-container-images#516

Steps to Test

  1. Create new dev-env
  2. Attach shell to php contianer and see that vip-config is loaded under /wp/vip-config and everything still works.

@rinatkhaziev
Copy link
Contributor

@pschoffer What would happen with the existing environments?

@pschoffer
Copy link
Contributor Author

Hmm I did test it before @rinatkhaziev but now I looked more into it and I found a scenario that breaks it a bit. I dropped the details in slack, but in essance if existing environment updates after this change and starts to mount vip-config to new location it might get ignored. Because we only update wp-config-defaults.php if wp-config.php doenst exist

@pschoffer
Copy link
Contributor Author

I think we should do this - https://github.com/Automattic/vip-container-images/pull/519/files that way update won't break existing environments after this change.

@sjinks sjinks added the [Status] Keep Prevent the "stale" workflow from auto-closing label Sep 28, 2023
@sjinks sjinks force-pushed the trunk branch 2 times, most recently from ce8ac7d to 50cb74a Compare November 7, 2023 08:40
@rbcorrales
Copy link
Member

@rinatkhaziev Is there anything we can do to move this PR forward? It seems that the work required on the vip-container-images repo was already handled. Let me know if there's anything I can do to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Keep Prevent the "stale" workflow from auto-closing [Status] Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants