Add support for other post types #539
Conversation
liveblog.php
Outdated
| @@ -250,7 +251,11 @@ public static function init() { | |||
| * Add liveblog support to the 'post' post type. This is done here so | |||
| * we can possibly introduce this to other post types later. | |||
| */ | |||
| add_post_type_support( 'post', self::KEY ); | |||
| $post_types = array( 'post' ); | |||
| self::$supported_post_types = apply_filters( 'liveblog_modify_supported_post_types', $post_types ); | |||
There was a problem hiding this comment.
This filter should be documented.
There was a problem hiding this comment.
I would rename it to liveblog_supported_post_types
liveblog.php
Outdated
| /** | ||
| * Filters post types supported by liveblog. | ||
| * | ||
| * @since 2.0 |
There was a problem hiding this comment.
Change this to 2.0.0. Versions should use the 3-digit style.
liveblog.php
Outdated
| * | ||
| * @since 2.0 | ||
| * | ||
| * @param array An array of supported post types. |
There was a problem hiding this comment.
The type is already specified as an array, so the description can just be Supported post types.
liveblog.php
Outdated
| self::$supported_post_types = apply_filters( 'liveblog_modify_supported_post_types', $post_types ); | ||
|
|
||
| /** | ||
| * Filters post types supported by liveblog. |
There was a problem hiding this comment.
There is a plan to possibly change the name of the plugin, so maybe change liveblog here to be this plugin?
There was a problem hiding this comment.
Are we changing the name in this release?
If not, I think this should stay as liveblog as it'll be easier to change the prefix with a search-replace when the name is finalised.
There was a problem hiding this comment.
The prefix on the filter is unlikely to change, unless it was aiming to break BC.
In this case, it was just the name in the filter description (line 257), that I was referring to.
Not a biggie - there are likely other instances of "liveblog" in other DocBlocks as well that would need changing.
Addresses #223.
Submitting a new PR because the changes from this PR were lost.
liveblog_modify_supported_post_typesfilter in theinit()method.pagepost type in the previous PR.get_liveblog_state()andis_viewing_liveblog_post()to accommodate additional post types.