Added: Changelog Feature #61

Kille135 · 2024-03-28T20:51:27Z

No description provided.

ales-tsurko

I leaved a comment. And also, maybe I'm wrong, but your pipeline updates the changelog for every pull request, while we need to update it only for testnet release (when we git tag it).

ales-tsurko · 2024-04-08T13:25:11Z

.github/workflows/changelog.yml

+        run: |
+          PR_TITLE=$(jq -r ".pull_request.title" "$GITHUB_EVENT_PATH")
+          # Check if the pull request title matches the required format
+          if ! echo "$PR_TITLE" | grep -qE '^(Added|Changed|Deprecated|Removed|Fixed|Security): .+$'; then


The problem here that it violates our style guideline for commmit messages, particularly:

the first word is a verb, but not in imperative form

it has punctuation symbols we don't need

But it's ok to restrict the words list for merge commits to: "Add", "Change", "Deprecate", "Remove", "Fix". Don't know what to do about "Security". Can we remove it completely?

Also, we need to update our contributing guideline accordingly (the title of a PR can have only these words and the merge request message should be the same as the PR title).

ales-tsurko · 2024-04-08T13:44:12Z

Also, please change the file name to CHANGELOG.md (all capital)

Kille135 added 30 commits March 28, 2024 16:50

Rename Changelog to Changelog.md

8248889

Added Changelog.yml

978978c

Update Changelog.yml

491ede5

Update Changelog.yml

8733dab

Added Changelog generation and Pull Request message validation

3b80088

Update deploy-testnet.yml

44f7072

Fixed docker image push in CI/CD workflow (#57)

5d37cfb

Update Changelog.yml

2111d3d

Update Changelog.yml

bcff82b

Update Changelog.yml

d128529

Added: Pull-Request title check and Changelog feature (#59)

4a89339

Update Changelog.yml

1aca207

Update Changelog.yml

2f2800d

Delete .github/workflows/Changelog.yml

04da366

Changelog CI deleted

80b37ef

Create changelog.yml

bd154a0

Update changelog.yml

7daaa9c

Update changelog.yml

db9437c

Update changelog.yml

2e82ccd

Update changelog.yml

537b4e3

Update changelog.yml

8e25e82

Update changelog.yml

65a0a7a

Update changelog.yml

e712e64

Update changelog.yml

c47470b

Update changelog.yml

a860b6a

Update changelog.yml

7075dff

Update changelog.yml

1f569a2

Update changelog.yml

96b44c0

Update changelog.yml

3b00c83

Update changelog.yml

0c905f6

Kille135 and others added 21 commits April 1, 2024 09:51

Update changelog.yml

615e1e0

Update changelog.yml

2c3e6f3

Update changelog.yml

14ba853

Update changelog.yml

19ab5d3

Update changelog.yml

253a7b3

Update changelog.yml

cbfd010

Update changelog.yml

c979e6c

Update changelog.yml

2c3a57c

Update changelog.yml

97bdef4

Update changelog.yml

6bcba4c

Update changelog.yml

bfb3cf8

Update changelog.yml

c64c3aa

Update changelog.yml

5330043

Update changelog.yml

7c74eb1

Update changelog.yml

21e25c2

Update changelog.yml

4e70f4c

Update changelog.yml

b9d82fb

Update changelog.yml

75f9b24

Update changelog.yml

065bba7

Update changelog.yml

f172fc6

Update Changelog with changes from pull request #61

2f8fe61

Kille135 force-pushed the testnet branch 2 times, most recently from 5d37cfb to 8078129 Compare April 2, 2024 13:26

ales-tsurko requested changes Apr 8, 2024

View reviewed changes

ales-tsurko marked this pull request as draft April 8, 2024 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added: Changelog Feature #61

Added: Changelog Feature #61

Kille135 commented Mar 28, 2024

ales-tsurko left a comment

ales-tsurko Apr 8, 2024

ales-tsurko commented Apr 8, 2024

Added: Changelog Feature #61

Are you sure you want to change the base?

Added: Changelog Feature #61

Conversation

Kille135 commented Mar 28, 2024

ales-tsurko left a comment

Choose a reason for hiding this comment

ales-tsurko Apr 8, 2024

Choose a reason for hiding this comment

ales-tsurko commented Apr 8, 2024