Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBalance as default dapp-staking reward destination #975

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Changes default reward destination from StakeBalance to FreeBalance for dApp staking.
Applies to all runtimes.

Check list

  • added or updated unit tests
  • updated spec version
  • updated semver

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jul 11, 2023
@ashutoshvarma
Copy link
Member

CI is failing due to some issue in mock runtime.
Also why are we changing the default?

@Dinonard
Copy link
Member Author

CI is failing due to some issue in mock runtime. Also why are we changing the default?

It was requested by BizDev & UI team, due to integration with the Ledger.
They will not support set_reward_destination for old devices, so it would be unfair to force users to keep restaking, without the possibility to claim into free balance.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/block-reward/src 85% 0%
pallets/ethereum-checked/src 69% 0%
pallets/pallet-xcm/src 54% 0%
chain-extensions/xvm/src 0% 0%
pallets/pallet-xvm/src 5% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/contracts-migration/src 0% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/sr25519/src 79% 0%
precompiles/utils/src 69% 0%
pallets/xc-asset-config/src 54% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/utils/macro/src 0% 0%
pallets/dapps-staking/src 82% 0%
precompiles/xcm/src 85% 0%
pallets/custom-signatures/src 52% 0%
precompiles/xvm/src 61% 0%
primitives/src 72% 0%
primitives/src/xcm 70% 0%
precompiles/assets-erc20/src 76% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/dapps-staking/src/pallet 87% 0%
pallets/pallet-xvm/src/pallet 8% 0%
precompiles/substrate-ecdsa/src 78% 0%
pallets/collator-selection/src 70% 0%
Summary 55% (2243 / 4061) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dinonard Dinonard merged commit 21d0566 into master Jul 13, 2023
12 checks passed
@Dinonard Dinonard deleted the feat/dapp-staking-free-balance-default-reward branch July 13, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants