Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.26.0 prep #1097

Merged
merged 3 commits into from
Dec 5, 2023
Merged

v5.26.0 prep #1097

merged 3 commits into from
Dec 5, 2023

Conversation

PierreOssun
Copy link
Member

@PierreOssun PierreOssun commented Dec 5, 2023

Pull Request Summary

bump version for v5.26.0

Adding:

  • XCM native fee reduction #1092
  • fix(AU): [AST-1] prevent account from being reaped while charging fee #1094
  • Add Hybrid Inflation to Shiden #1095

@PierreOssun PierreOssun added the runtime This PR/Issue is related to the topic “runtime”. label Dec 5, 2023
Dinonard
Dinonard previously approved these changes Dec 5, 2023
@@ -1062,36 +1062,10 @@ parameter_types! {
pub const BaseFeeStr: &'static str = "BaseFee";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove this.

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 5, 2023

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapps-staking/src/pallet 85% 0%
precompiles/sr25519/src 79% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/unified-accounts/src 84% 0%
primitives/src/xcm 66% 0%
precompiles/xvm/src 75% 0%
chain-extensions/types/assets/src 0% 0%
pallets/collator-selection/src 69% 0%
precompiles/utils/macro/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/block-reward/src 85% 0%
precompiles/utils/src/testing 38% 0%
pallets/contracts-migration/src 0% 0%
precompiles/xcm/src 75% 0%
pallets/dapps-staking/src 81% 0%
precompiles/dapps-staking/src 93% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/xc-asset-config/src 53% 0%
chain-extensions/pallet-assets/src 0% 0%
precompiles/substrate-ecdsa/src 78% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/utils/src 55% 0%
pallets/xvm/src 40% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/block-rewards-hybrid/src 87% 0%
precompiles/assets-erc20/src 77% 0%
primitives/src 65% 0%
pallets/ethereum-checked/src 48% 0%
chain-extensions/dapps-staking/src 0% 0%
Summary 57% (2278 / 4017) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreOssun PierreOssun merged commit 1cff317 into master Dec 5, 2023
8 checks passed
@PierreOssun PierreOssun deleted the feat/v5.26.0-prep branch December 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants