Skip to content

Commit

Permalink
Fix rpc tests issues (#985)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dinonard authored Jul 27, 2023
1 parent b83fea8 commit 53500c1
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ jobs:
- name: Copy zombinet testing binary
run: |
wget https://github.com/paritytech/zombienet/releases/download/v1.3.35/zombienet-linux-x64
wget https://github.com/paritytech/zombienet/releases/download/v1.3.63/zombienet-linux-x64
chmod +x ./zombienet-linux-x64
mv zombienet-linux-x64 rpc-tests/bin/zombienet-linux-x64
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ $ ./target/release/astar-collator \
--base-path <path to save blocks> \
--name <node display name> \
--port 30333 \
--ws-port 9944 \
--rpc-port 9933 \
--rpc-port 9944 \
--telemetry-url 'wss://telemetry.polkadot.io/submit/ 0' \
--rpc-cors all \
--collator
Expand Down
2 changes: 1 addition & 1 deletion rpc-tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ cp target/release/astar-collator rpc-tests/bin/astar-collator

Download and copy latest polkadot binary from https://github.com/paritytech/polkadot/releases to rpc-tests/bin folder

Download and copy latest zombinet binary from https://github.com/paritytech/zombinet/releases to rpc-tests/bin folder
Download and copy latest zombienet binary from https://github.com/paritytech/zombienet/releases to rpc-tests/bin folder

To start the test suite.

Expand Down
6 changes: 2 additions & 4 deletions rpc-tests/rpc-tests.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ cumulus_based = true
[parachains.collator]
name = "astar"
command = "./astar-collator"
ws_port = 9944
rpc_port = 8545
rpc_port = 9944
args = [ "-l=xcm=trace", "--enable-evm-rpc" ]

[[parachains]]
Expand All @@ -37,8 +36,7 @@ cumulus_based = true
[parachains.collator]
name = "shiden"
command = "./astar-collator"
ws_port = 9945
rpc_port = 8546
rpc_port = 9945
args = [ "-l=xcm=trace", "--enable-evm-rpc" ]

[[hrmp_channels]]
Expand Down
4 changes: 2 additions & 2 deletions rpc-tests/tests/0002-deploy-an-evm-contract.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
async function run(nodeName, networkInfo, args) {
networkInfo.nodesByName["astar"].rpcPort = 8545
networkInfo.nodesByName["shiden"].rpcPort = 8546
networkInfo.nodesByName["astar"].rpcPort = 9944
networkInfo.nodesByName["shiden"].rpcPort = 9945

const { rpcPort } = networkInfo.nodesByName[nodeName];
const { compiled } = await import("./compile.mjs");
Expand Down
4 changes: 2 additions & 2 deletions rpc-tests/tests/0002-get-evm-contract-data.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
async function run(nodeName, networkInfo, args) {
networkInfo.nodesByName["astar"].rpcPort = 8545
networkInfo.nodesByName["shiden"].rpcPort = 8546
networkInfo.nodesByName["astar"].rpcPort = 9944
networkInfo.nodesByName["shiden"].rpcPort = 9945

const {rpcPort} = networkInfo.nodesByName[nodeName];
const { compiled } = await import("./compile.mjs");
Expand Down
4 changes: 2 additions & 2 deletions rpc-tests/tests/0002-set-evm-contract-data.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
async function run(nodeName, networkInfo, args) {
networkInfo.nodesByName["astar"].rpcPort = 8545
networkInfo.nodesByName["shiden"].rpcPort = 8546
networkInfo.nodesByName["astar"].rpcPort = 9944
networkInfo.nodesByName["shiden"].rpcPort = 9945

const {rpcPort} = networkInfo.nodesByName[nodeName];
const { compiled } = await import("./compile.mjs");
Expand Down

0 comments on commit 53500c1

Please sign in to comment.