Improvement/navigation architecture #73
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| package com.architectcoders.equipocinco.common | ||
|
|
||
| import android.os.Bundle | ||
| import androidx.fragment.app.Fragment | ||
| import com.architectcoders.equipocinco.R | ||
| import com.architectcoders.equipocinco.ui.activity.MainActivity | ||
| import com.ncapdevi.fragnav.FragNavController | ||
| import com.ncapdevi.fragnav.FragNavLogger | ||
| import com.ncapdevi.fragnav.FragNavSwitchController | ||
| import com.ncapdevi.fragnav.FragNavTransactionOptions | ||
| import com.ncapdevi.fragnav.tabhistory.UniqueTabHistoryStrategy | ||
| import kotlinx.android.synthetic.main.activity_main.* | ||
|
|
||
| class FragmentFrameHelper(private val activity: MainActivity) { | ||
| companion object { | ||
| const val INDEX_POPULAR = FragNavController.TAB1 | ||
| const val INDEX_TOP_RATED = FragNavController.TAB2 | ||
| const val INDEX_FAVOURITE = FragNavController.TAB3 | ||
| } | ||
|
|
||
| private val fragNavController: FragNavController = | ||
| FragNavController(activity.supportFragmentManager, R.id.navHostFragment) | ||
|
|
||
|
|
||
| fun setupNavController(savedInstanceState: Bundle?) { | ||
| fragNavController.apply { | ||
| rootFragmentListener = activity | ||
| createEager = true | ||
| fragNavLogger = object : FragNavLogger { | ||
| override fun error(message: String, throwable: Throwable) { | ||
| } | ||
| } | ||
|
|
||
| defaultTransactionOptions = FragNavTransactionOptions.newBuilder().customAnimations( | ||
| R.anim.slide_in_from_right, | ||
| R.anim.slide_out_to_left, | ||
| R.anim.slide_in_from_left, | ||
| R.anim.slide_out_to_right | ||
| ).build() | ||
| fragmentHideStrategy = FragNavController.DETACH_ON_NAVIGATE_HIDE_ON_SWITCH | ||
|
|
||
| navigationStrategy = UniqueTabHistoryStrategy(object : FragNavSwitchController { | ||
| override fun switchTab(index: Int, transactionOptions: FragNavTransactionOptions?) { | ||
| activity.bottom_navigation_view.selectTabAtPosition(index) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| fragNavController.initialize(INDEX_POPULAR, savedInstanceState) | ||
| val initial = savedInstanceState == null | ||
| if (initial) { | ||
| activity.bottom_navigation_view.selectTabAtPosition(INDEX_POPULAR) | ||
| } | ||
|
|
||
| activity.bottom_navigation_view.setOnTabSelectListener({ tabId -> | ||
| when (tabId) { | ||
| R.id.menu_popular -> fragNavController.switchTab(INDEX_POPULAR) | ||
| R.id.menu_top_rated -> fragNavController.switchTab(INDEX_TOP_RATED) | ||
| R.id.menu_favourites -> fragNavController.switchTab(INDEX_FAVOURITE) | ||
| } | ||
| }, initial) | ||
|
|
||
| activity.bottom_navigation_view.setOnTabReselectListener { fragNavController.clearStack() } | ||
|
|
||
|
|
||
| } | ||
|
|
||
| fun pushFragment(fragment: Fragment) { | ||
| fragNavController.pushFragment(fragment) | ||
| } | ||
|
|
||
| fun onSaveInstanceState(outState: Bundle) { | ||
| fragNavController.onSaveInstanceState(outState) | ||
| } | ||
|
|
||
| fun popFragmentNot(): Boolean = fragNavController.popFragment().not() | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.architectcoders.equipocinco.extensions | ||
|
|
||
| import android.os.Bundle | ||
| import com.architectcoders.equipocinco.ui.fragment.detail.DetailMovieFragment | ||
| import com.architectcoders.equipocinco.ui.fragment.master.child.FavouriteMoviesFragment | ||
| import com.architectcoders.equipocinco.ui.fragment.master.child.PopularMoviesFragment | ||
| import com.architectcoders.equipocinco.ui.fragment.master.child.TopRatedMoviesFragment | ||
|
|
||
| fun PopularMoviesFragment.Companion.newInstance(): PopularMoviesFragment = PopularMoviesFragment() | ||
|
|
||
| fun TopRatedMoviesFragment.Companion.newInstance(): TopRatedMoviesFragment = TopRatedMoviesFragment() | ||
|
|
||
| fun FavouriteMoviesFragment.Companion.newInstance(): FavouriteMoviesFragment = FavouriteMoviesFragment() | ||
|
|
||
| //Detail Movie instance | ||
| fun DetailMovieFragment.Companion.newInstance(id: Int): DetailMovieFragment { | ||
| val args = Bundle() | ||
| args.putInt(MOVIE_ID_KEY, id) | ||
| val fragment = DetailMovieFragment() | ||
| fragment.arguments = args | ||
| return fragment | ||
|
|
||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,59 @@ | ||
| package com.architectcoders.equipocinco.ui.activity | ||
|
|
||
| import android.os.Bundle | ||
| import android.view.View | ||
| import androidx.appcompat.app.AppCompatActivity | ||
| import androidx.fragment.app.Fragment | ||
| import com.architectcoders.equipocinco.R | ||
| import com.architectcoders.equipocinco.common.FragmentFrameHelper | ||
| import com.architectcoders.equipocinco.common.FragmentFrameHelper.Companion.INDEX_FAVOURITE | ||
| import com.architectcoders.equipocinco.common.FragmentFrameHelper.Companion.INDEX_POPULAR | ||
| import com.architectcoders.equipocinco.common.FragmentFrameHelper.Companion.INDEX_TOP_RATED | ||
| import com.architectcoders.equipocinco.extensions.newInstance | ||
| import com.architectcoders.equipocinco.ui.fragment.BaseFragment | ||
| import com.architectcoders.equipocinco.ui.fragment.master.child.FavouriteMoviesFragment | ||
| import com.architectcoders.equipocinco.ui.fragment.master.child.PopularMoviesFragment | ||
| import com.architectcoders.equipocinco.ui.fragment.master.child.TopRatedMoviesFragment | ||
| import com.ncapdevi.fragnav.FragNavController | ||
|
|
||
| class MainActivity : AppCompatActivity(), FragNavController.RootFragmentListener, | ||
| BaseFragment.FragmentNavigation { | ||
|
|
||
| private val fragmentHelper = FragmentFrameHelper(this) | ||
| private lateinit var activity: MainActivity | ||
| override val numberOfRootFragments: Int = 3 | ||
|
|
||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| setTheme(R.style.AppTheme) | ||
| setContentView(R.layout.activity_main) | ||
| fragmentHelper.setupNavController(savedInstanceState) | ||
| activity = this@MainActivity | ||
| } | ||
|
|
||
|
|
||
| override fun onSaveInstanceState(outState: Bundle) { | ||
| super.onSaveInstanceState(outState) | ||
| fragmentHelper.onSaveInstanceState(outState) | ||
| } | ||
|
|
||
| override fun onBackPressed() { | ||
| if (fragmentHelper.popFragmentNot()) { | ||
| super.onBackPressed() | ||
| } | ||
| } | ||
|
|
||
| override fun getRootFragment(index: Int): Fragment { | ||
| when (index) { | ||
| INDEX_POPULAR -> { return PopularMoviesFragment.newInstance() } | ||
| INDEX_TOP_RATED -> return TopRatedMoviesFragment.newInstance() | ||
| INDEX_FAVOURITE -> return FavouriteMoviesFragment.newInstance() | ||
| } | ||
| throw IllegalStateException("Need to send an index that we know") | ||
| } | ||
|
|
||
| override fun pushFragment(fragment: Fragment, sharedElementList: List<Pair<View, String>>?) { | ||
| fragmentHelper.pushFragment(fragment) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package com.architectcoders.equipocinco.ui.fragment | ||
|
|
||
| import android.content.Context | ||
| import android.view.View | ||
| import androidx.fragment.app.Fragment | ||
|
|
||
|
|
||
| abstract class BaseFragment : Fragment() { | ||
|
|
||
| lateinit var mFragmentNavigation: FragmentNavigation | ||
|
|
||
| override fun onAttach(context: Context) { | ||
| super.onAttach(context) | ||
| if (context is FragmentNavigation) { | ||
| mFragmentNavigation = context | ||
| } | ||
| } | ||
|
|
||
| interface FragmentNavigation { | ||
| fun pushFragment(fragment: Fragment, sharedElementList: List<Pair<View, String>>? = null) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aqui puedes personalizar la estrategia del stack de fragments, ahora tenemos DETACH_ON_NAVIGATE_HIDE_ON_SWITCH que basicamente significa q en nuestro caso siempre tendria 3 vistas en memorias a la vez, no importa en que nivel de profundidad estes. Por ejemplo: si estas en detailMovie del TAB de popularMovies, tendrías en memoria estas 3, DetailScreen(de popularMovie), TopRatedScreen y FavouriteScreen , y si le das hacia atras desde DetailScreen, tendrias ahora estas vistas PopularMovie, TopRatedScreen y FavouriteScreen en memoria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuando vas en niveles dentro de un mismo TAB, por ej. desde PopularMovies a detail, se hace un detach del fragment de modo que se destruye la View del fragment de PopularMocies pero queda la instancia del objeto en memoria, y en consecuencia el ViewModel sobrevive tambien conteniendo en sus LiveDatas los ultimos valores. Por eso tuve que hacer un wrapper del object Navigation en un Event en el onSelectedMovie y preguntar si ya se habia consumido anteriormente, de otro modo me volveria de nuevo al detailscreen y no me dejaria ir nunca hacia atras
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brutal! Gracias por la explicación!