Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'delete line' command shortcut #906

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Sep 30, 2024

Press Cmd (on Mac) or Ctrl (on Windows/Linux) + X will:

  • If the selection is collapsed, delete the current line.
  • If the selection is not collapsed, do nothing.

related to AppFlowy-IO/AppFlowy#6425

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.89%. Comparing base (d049584) to head (19ec996).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._component/base_component/delete_line_command.dart 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   71.87%   71.89%   +0.02%     
==========================================
  Files         318      319       +1     
  Lines       14943    14959      +16     
==========================================
+ Hits        10740    10755      +15     
- Misses       4203     4204       +1     
Flag Coverage Δ
71.89% <93.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 54edcad into AppFlowy-IO:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant