add flag to specify if messages are multimodal #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comhar
force-pushed
the
text-only-support
branch
from
0604588
to
cb62be6
Compare
comhar
commented
Sep 18, 2024
| **kwargs): | ||
| "Helper to create a `dict` appropriate for a message. `kwargs` are added as key/value pairs to the message" | ||
| if hasattr(content, 'content'): content,role = content.content,content.role | ||
| if isinstance(content, ChatCompletion): return find_block(content) | ||
| if content is not None and not isinstance(content, list): content=[content] | ||
| content = [_mk_content(o) for o in content] if content else '' | ||
| if content and not multimodal: content = " .".join(content) |
There was a problem hiding this comment.
Is this a reasonable way to join the list? I guess "\n" would be another option.
|
This looks like pretty much the same format as claudette. Could you see if you can pull some of that functionality out into some shared utilities or base class or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to specify if your messages are multimodal. This is useful because some text-only models like DeepSeek expect messages with the following format:
{"role": "user", "content": "some message"}Currently cosette only generates messages with the format below which throws an error when calling the DeepSeek API. This isn't unique to DeepSeek. The same error occurs with models hosted by other providers like Groq.
{"role": "user", "content": [{"type": "text", "text": "some message"}]}