Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds DataSpaces 2 support and GitHub CI #2

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Adds DataSpaces 2 support and GitHub CI #2

merged 6 commits into from
Feb 20, 2024

Conversation

ilumsden
Copy link
Collaborator

@ilumsden ilumsden commented Feb 14, 2024 •
edited
Loading

This PR does 3 things:

  1. It adds support for DataSpaces 2
  2. It adds a GitHub CI workflow that ensures A4MD builds and runs with DataSpaces 2
  3. It replaces the deprecated FindPythonInterp and FindPythonLibs-based approach to finding Python with the newer FindPython3 CMake module

@ilumsden ilumsden added the enhancement New feature or request label Feb 14, 2024
@ilumsden ilumsden self-assigned this Feb 14, 2024
@ilumsden ilumsden marked this pull request as ready for review February 20, 2024 17:35
@jackdmarquez jackdmarquez merged commit 375f5a5 into master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackdmarquez jackdmarquez Awaiting requested review from jackdmarquez

Assignees

@ilumsden ilumsden

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilumsden @jackdmarquez