orc 2.0.1 #11
Merged
orc 2.0.1 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…da-forge-pinning 2020.12.04.08.17.45
…314-0-1_h9a7a2c Rebuild for libprotobuf314
…da-forge-pinning 2020.12.31.20.36.09
…1_hd98ab0 Rebuild for lz4-c193
…da-forge-pinning 2021.01.22.19.19.10
…da-forge-pinning 2021.02.20.20.42.23
…da-forge-pinning 2021.02.21.18.29.10
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2021.05.07.14.12.29
…316-0-1_h6412fa Rebuild for libprotobuf316
…nda-forge-pinning 2021.05.16.17.33.49
…h7b2760 Rebuild for zstd15
…nda-forge-pinning 2021.07.02.15.37.15
…nda-forge-pinning 2021.08.08.03.57.11
…nda-forge-pinning 2024.03.06.12.50.32
…libprotobuf4253-0-1_h94d986 Rebuild for libprotobuf 4.25.3
…nda-forge-pinning 2024.04.08.16.26.39
…-1_he55bc0 Rebuild for snappy120
…ForgeAutomergeUpdate
…nda-forge-pinning 2024.05.15.08.40.24
add runtime dependence on tzdata
danpetry
reviewed
May 28, 2024
| - libabseil # [win] | ||
| - lz4-c | ||
| - zstd | ||
| - __osx >={{ MACOSX_DEPLOYMENT_TARGET }} # [osx and x86_64] |
There was a problem hiding this comment.
can this be done through macos_min_version?
There was a problem hiding this comment.
All our feedstock use MACOSX_DEPLOYMENT_TARGET to set this constraint.
There was a problem hiding this comment.
yeah I see, it's a common pattern. out of interest, does macos_min_version do exactly the same thing do you know?
skupr-anaconda
approved these changes
May 29, 2024
recipe/conda_build_config.yaml
Outdated
Comment on lines
1
to
4
| cxx_compiler: # [win] | ||
| - 'vs2019' # [win] | ||
| c_compiler: # [win] | ||
| - 'vs2019' # [win] |
There was a problem hiding this comment.
This can be removed as vs2019 is already a default compiler in a generic cbc.yaml on win64
danpetry
approved these changes
May 29, 2024
recipe/build.sh
Outdated
| @@ -16,9 +16,9 @@ if [[ ${HOST} =~ .*darwin.* ]]; then | |||
| _CMAKE_EXTRA_CONFIG+=(-DCMAKE_AR=${AR}) | |||
| _CMAKE_EXTRA_CONFIG+=(-DCMAKE_RANLIB=${RANLIB}) | |||
| _CMAKE_EXTRA_CONFIG+=(-DCMAKE_LINKER=${LD}) | |||
| CXXFLAGS="${CXXFLAGS} -DPROTOBUF_USE_DLLS -D_LIBCPP_DISABLE_AVAILABILITY" | |||
There was a problem hiding this comment.
-DPROTOBUF_USE_DLLS sounds like a windows flag, not a macos one
| fi | ||
| if [[ ${HOST} =~ .*linux.* ]]; then | ||
| CXXFLAGS="${CXXFLAGS//-std=c++17/-std=c++11}" | ||
| # I hate you so much CMake. | ||
| LIBPTHREAD=$(find ${PREFIX} -name "libpthread.so") | ||
| _CMAKE_EXTRA_CONFIG+=(-DPTHREAD_LIBRARY=${LIBPTHREAD}) |
There was a problem hiding this comment.
export LDFLAGS="${LDFLAGS} -Wl,-rpath,$PREFIX/lib" instead of CPPFLAGS? (the current implementation seems to be working however)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orc 2.0.1
Destination channel: main
Links
Explanation of changes: