Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG-4723 20240116.2 #9

Merged
merged 125 commits into from
May 24, 2024
Merged

PKG-4723 20240116.2 #9

merged 125 commits into from
May 24, 2024

Conversation

cbouss
Copy link

@cbouss cbouss commented May 9, 2024

regro-cf-autotick-bot and others added 30 commits March 29, 2021 19:27
automerged PR by conda-forge/automerge-action
Copy link

@danpetry danpetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started looking at this, will split over multiple days as it's v big.
If you're able to isolate the relevant discussions for the changes on conda-forge that would be helpful; the links include discussions around historical updates, protobuf, etc. (or do I need to read the whole thing for context..?)

- cmake
- ninja-base
host:
- gtest 1.14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see where gtest is being used, or the test binaries are being used (beyond checking that they're present)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for abseil_test_dll, included in this pacakge.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the test binaries get run? or does it ship a test suite for use by devs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libprotobuf does make use of abseil test binaries to built its own test binaries

@cbouss
Copy link
Author

cbouss commented May 14, 2024

Started looking at this, will split over multiple days as it's v big. If you're able to isolate the relevant discussions for the changes on conda-forge that would be helpful; the links include discussions around historical updates, protobuf, etc. (or do I need to read the whole thing for context..?)

Tp put it short, all packages depending on abseil must be built with cxx 17 at least. Also, even minor updates can induce breaking changes. The other relevant change is conda-forge renaming the package from abseil-cpp to libabseil.

@cbouss cbouss merged commit ace7acd into master May 24, 2024
8 checks passed
@cbouss cbouss deleted the PKG-4723 branch May 24, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.