support multiple evm chains #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
previously approved these changes
Oct 30, 2020
samparsky
force-pushed
the
fix/multiple-evm-chain
branch
from
096f8b2
to
f2eb179
Compare
samparsky
force-pushed
the
fix/multiple-evm-chain
branch
from
12e31e8
to
b8e65d1
Compare
ivopaunov
requested changes
Feb 22, 2021
| const provider = | ||
| ethProvider || | ||
| (depositChainId && new providers.JsonRpcProvider(cfg.supportedChainIdsByRPC[depositChainId])) || | ||
| getDefaultProvider(cfg.ETHEREUM_NETWORK) |
There was a problem hiding this comment.
there is no ETHEREUM_NETWORK in the cfg - it is NETWORK. In docs/configuration.md it's ETHEREUM_NETWORK - just has to be NETWORK everywhere I guess.
ivopaunov
reviewed
Feb 22, 2021
| const provider = | ||
| ethProvider || | ||
| (depositChainId && new providers.JsonRpcProvider(cfg.supportedChainIdsByRPC[depositChainId])) || | ||
| getDefaultProvider(cfg.ETHEREUM_NETWORK) |
There was a problem hiding this comment.
should check cfg.supportedChainIdsByRPC[depositChainId] before new providers.JsonRpcProvider... as at the moment cfg.supportedChainIdsByRPC is empty and I'm not sure if it will throw or use default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324