Skip to content

Commit

Permalink
Merge pull request #296 from AmbireTech/bidding-mode
Browse files Browse the repository at this point in the history
add filter by placement for admin  analytics
  • Loading branch information
ivopaunov authored Sep 24, 2024
2 parents 4fa771a + d53ae6c commit 32295d6
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 5 deletions.
22 changes: 20 additions & 2 deletions src/components/AdminPanel/AdminAnalytics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ const sspsData: Array<{ value: SSPs; label: string }> = [
{ value: 'Qortex', label: 'Qortex' }
]

type Placements = '' | 'app' | 'site'

const placementData: Array<{ value: Placements; label: string }> = [
{ value: '', label: 'All Placements' },
{ value: 'app', label: 'App' },
{ value: 'site', label: 'Site' }
]

const mapSegmentLabel = (analType: AnalyticsType, segment: string): { segementLabel: string } => {
let segementLabel = segment

Expand Down Expand Up @@ -103,6 +111,7 @@ const AdminAnalytics = () => {
const [timeframe, setTimeframe] = useState<Timeframe>('month')
const [analType, setAnalType] = useState<AnalyticsType>('ssp')
const [ssp, setSsp] = useState<SSPs>('')
const [placement, setPlacement] = useState<Placements>('')
const [startDate, setStartDate] = useState<Date | null>(
dayjs().subtract(1, 'month').startOf('month').toDate()
)
Expand Down Expand Up @@ -151,14 +160,15 @@ const AdminAnalytics = () => {
timeframe,
startDate || undefined,
end || undefined,
ssp || undefined
ssp || undefined,
placement || undefined
)
setAnalyticsKey(key)
console.log('key', key)
}

checkAnalytics()
}, [analType, getAnalyticsKeyAndUpdate, ssp, startDate, timeframe])
}, [analType, getAnalyticsKeyAndUpdate, placement, ssp, startDate, timeframe])

const loading = useMemo(() => adminMappedAnalytics?.status === 'loading', [adminMappedAnalytics])

Expand Down Expand Up @@ -242,6 +252,14 @@ const AdminAnalytics = () => {
data={sspsData}
size="md"
/>
<Select
label="Placement"
value={placement}
// @ts-ignore
onChange={(val) => setPlacement(val as Placements)}
data={placementData}
size="md"
/>
<Select
label="Period"
value={timeframe}
Expand Down
9 changes: 6 additions & 3 deletions src/contexts/CampaignsContext/CampaignsAnalyticsContext.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Campaign } from 'adex-common'
import { Campaign, Placement } from 'adex-common'
import {
createContext,
FC,
Expand Down Expand Up @@ -153,7 +153,8 @@ interface ICampaignsAnalyticsContext {
timeframe?: Timeframe,
startFrom?: Date,
endTo?: Date,
ssp?: SSPs
ssp?: SSPs,
placement?: Placement
) => Promise<{ key: string; period: AnalyticsPeriod } | undefined>
initialAnalyticsLoading: boolean
mappedAnalytics: Map<string, MappedAnalyticsRecord>
Expand Down Expand Up @@ -238,7 +239,8 @@ const CampaignsAnalyticsProvider: FC<PropsWithChildren> = ({ children }) => {
selectedTimeframe?: Timeframe,
startFrom?: Date,
endTo?: Date,
ssp?: SSPs
ssp?: SSPs,
placement?: Placement
): Promise<{ key: string; period: AnalyticsPeriod } | undefined> => {
if (!analyticsType || (!forAdmin && !campaign?.id)) {
return
Expand Down Expand Up @@ -286,6 +288,7 @@ const CampaignsAnalyticsProvider: FC<PropsWithChildren> = ({ children }) => {
timezone: 'UTC',
timeframe,
...{ ssp },
...{ placement },
segmentBy: analyticsType === 'timeframe' ? undefined : analyticsType
}

Expand Down

0 comments on commit 32295d6

Please sign in to comment.