Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace-builders): create a script to extract deprecated items #2262

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Oct 10, 2024

Proposed change

feat(workspace-builders): create a script to extract deprecated items
feat: split workspace helpers and build helpers

@kpanot kpanot requested a review from a team as a code owner October 10, 2024 06:48
@@ -59,3 +59,73 @@ The removal the timezone is now an 'opt-in' mechanism triggered by the `x-local-

> [!NOTE]
> You can revert to the previous behavior thanks to the global property `useLegacyDateExtension`
<!-- generated deprecated - start -->
Copy link
Contributor Author

@kpanot kpanot Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated with command yarn report-deprecates 11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a documentation where we can add this script usage example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a readme file

@kpanot kpanot force-pushed the feature/deprecation-check-tools branch 2 times, most recently from 8ad1146 to ae2839b Compare October 11, 2024 01:47
@kpanot kpanot force-pushed the feature/deprecation-check-tools branch from ae2839b to 2643489 Compare October 11, 2024 02:14
@kpanot kpanot force-pushed the feature/deprecation-check-tools branch from ea4cb8d to fbf919f Compare October 11, 2024 07:05
@kpanot kpanot force-pushed the feature/deprecation-check-tools branch from defb420 to a007f3e Compare October 13, 2024 14:26
@kpanot kpanot force-pushed the feature/deprecation-check-tools branch 2 times, most recently from 823a341 to e531ba8 Compare October 15, 2024 00:00
tools/@o3r/workspace-helpers/readme.md Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/readme.md Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/readme.md Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/readme.md Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/readme.md Outdated Show resolved Hide resolved
tools/@o3r/workspace-helpers/readme.md Outdated Show resolved Hide resolved
docs/components/PLACEHOLDERS.md Outdated Show resolved Hide resolved
migration-guides/11.0.md Show resolved Hide resolved
tools/@o3r/workspace-helpers/scripts/report-deprecates.mjs Outdated Show resolved Hide resolved
@kpanot kpanot force-pushed the feature/deprecation-check-tools branch from 13e3d42 to 5a5741a Compare October 18, 2024 09:36
feat: split workspace helpers and build helpers
@kpanot kpanot force-pushed the feature/deprecation-check-tools branch from 5a5741a to aa4c1a5 Compare October 18, 2024 09:37
@@ -29,7 +29,7 @@ or by disabling it for your generator in your `openapitools.json` file:
{
"$schema": "https://raw.githubusercontent.com/OpenAPITools/openapi-generator-cli/master/apps/generator-cli/src/config.schema.json",
"generator-cli": {
"version": "7.4.0", // Version of the Codegen downloaded by the cli - updated via the
"version": "7.4.0", // Version of the Codegen downloaded by the cli - updated via the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentence is not finished


### [prepare-doc-root-menu-template](./scripts/prepare-doc-root-menu-template.mjs)

The purpose of this script is to prepare the root menu template with the list of packages inside.\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The purpose of this script is to prepare the root menu template with the list of packages inside.\
The purpose of this script is to prepare the root menu template with the list of packages inside.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the linebreak, I think it makes sense here


### [report-deprecates](./scripts/report-deprecates.mjs)

The purpose of this script is to generate a report of the deprecated items in the repository code.\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The purpose of this script is to generate a report of the deprecated items in the repository code.\
The purpose of this script is to generate a report of the deprecated items in the repository code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants