Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Token - style builder #2251

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Design Token - style builder #2251

merged 1 commit into from
Oct 11, 2024

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Oct 9, 2024

@kpanot kpanot requested a review from a team as a code owner October 9, 2024 01:51
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 22b1a1d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 10 targets

Sent with 💌 from NxCloud.

@github-actions github-actions bot added bug Something isn't working deprecate The issue or pull request involves code deprecation documentation Improvements or additions to documentation enhancement New feature or request project:@o3r/design labels Oct 9, 2024
@kpanot kpanot changed the title Feature/design token style Design Token - style builder Oct 9, 2024
fpaul-1A
fpaul-1A previously approved these changes Oct 9, 2024
View reviewed changes
sdo-1A
sdo-1A reviewed Oct 9, 2024
View reviewed changes
packages/@o3r/design/builders/generate-style/index.js Outdated Show resolved Hide resolved
packages/@o3r/design/README.md Outdated Show resolved Hide resolved
packages/@o3r/design/README.md Outdated Show resolved Hide resolved
packages/@o3r/design/README.md Outdated Show resolved Hide resolved
packages/@o3r/design/README.md Outdated Show resolved Hide resolved
packages/@o3r/design/builders/generate-style/schema.ts Outdated Show resolved Hide resolved
packages/@o3r/design/builders/generate-style/schema.ts Outdated Show resolved Hide resolved
packages/@o3r/design/src/core/design-token/parsers/design-token.parser.spec.ts Outdated Show resolved Hide resolved
packages/@o3r/design/src/core/design-token/parsers/design-token.parser.spec.ts Outdated Show resolved Hide resolved
...s/@o3r/design/src/core/design-token/renderers/sass/design-token-definition.renderers.spec.ts Outdated Show resolved Hide resolved
fpaul-1A
fpaul-1A previously approved these changes Oct 9, 2024
View reviewed changes
sdo-1A
sdo-1A reviewed Oct 10, 2024
View reviewed changes
packages/@o3r/design/builders.json Outdated Show resolved Hide resolved
packages/@o3r/design/README.md Show resolved Hide resolved
packages/@o3r/design/builders/generate-style/helpers/style-renderer-options.ts Outdated Show resolved Hide resolved
packages/@o3r/design/builders/generate-style/schema.json Outdated Show resolved Hide resolved
packages/@o3r/design/builders/generate-style/schema.json Outdated Show resolved Hide resolved
packages/@o3r/design/src/core/design-token/renderers/design-token-style.renderer.ts Outdated Show resolved Hide resolved
packages/@o3r/design/src/core/design-token/renderers/sass/design-token-updater.renderers.ts Outdated Show resolved Hide resolved
packages/@o3r/design/src/core/design-token/renderers/sass/design-token-value.renderers.ts Outdated Show resolved Hide resolved
packages/@o3r/design/README.md Outdated Show resolved Hide resolved
packages/@o3r/design/builders/generate-style/schema.json Outdated Show resolved Hide resolved
@kpanot kpanot force-pushed the feature/design-token-style branch 2 times, most recently from e02e5dc to 0eaa3b2 Compare October 10, 2024 15:05
sdo-1A
sdo-1A previously approved these changes Oct 10, 2024
View reviewed changes
fpaul-1A
fpaul-1A previously approved these changes Oct 11, 2024
View reviewed changes
@kpanot
feat(design): add Sass renderer support
22b1a1d 
deprecate(design): duplicated `TokenReferenceRender` interface
feat(design): add generate-style builder supporting sass
deprecate(design): `generate-css` builder in favor of `generate-style` builder
doc(design): update readme to replace builder name
@kpanot kpanot enabled auto-merge October 11, 2024 14:20
@kpanot kpanot added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 9f7f981 Oct 11, 2024
29 checks passed
@kpanot kpanot deleted the feature/design-token-style branch October 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrednic-1A mrednic-1A mrednic-1A approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@sdo-1A sdo-1A sdo-1A left review comments

Assignees
No one assigned
Labels
bug Something isn't working deprecate The issue or pull request involves code deprecation documentation Improvements or additions to documentation enhancement New feature or request project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/schematics project:audit-gh-action project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/design project:@o3r/dynamic-content project:@o3r/eslint-config-otter project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/localization project:@o3r/logger project:@o3r/mobile project:@o3r/new-version project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/store-sync project:@o3r/storybook project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/training-tools project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpanot @mrednic-1A @fpaul-1A @sdo-1A