feat(ama-sdk): move ApiFetchClient to dedicated package #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpanot
commented
Sep 2, 2024
| @@ -116,6 +120,7 @@ | |||
| "@o3r/schematics": "<%= sdkCoreRange %>" | |||
| },<% } %> | |||
| "peerDependencies": { | |||
| "@ama-sdk/client-fetch": "<%= sdkCoreRange %>", | |||
There was a problem hiding this comment.
Mandatory because of api-mock.ts.
Created #2117 (containing breaking change) to remove it.
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
from
fef26e3
to
aff071a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9c7e9e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
7 times, most recently
from
cb879c0
to
842d52b
Compare
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
2 times, most recently
from
aaa0ba9
to
aa5d52a
Compare
| */ | ||
| export interface PluginAsyncStarter { | ||
| /** Determine if the action can start */ | ||
| canStart?(): boolean | Promise<boolean>; |
There was a problem hiding this comment.
Question for my personal knowledge
is there a difference with
Suggested change
| canStart?(): boolean | Promise<boolean>; | |
| canStart?: () => boolean | Promise<boolean>; |
There was a problem hiding this comment.
I copy pasted it from the core actually so I did not check the code.
I wonder if the diff is that this notation enforce the usage of class property.
packages/@ama-sdk/client-fetch/src/plugins/abort/abort.fetch.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Sep 3, 2024
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
from
aa5d52a
to
c8026d4
Compare
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
2 times, most recently
from
93ccefa
to
dac33b7
Compare
Closed
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
2 times, most recently
from
7dc2a86
to
cb06684
Compare
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
from
cb06684
to
be3325b
Compare
fpaul-1A
previously approved these changes
Sep 6, 2024
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
from
be3325b
to
3d104eb
Compare
fpaul-1A
previously approved these changes
Sep 11, 2024
kpanot
force-pushed
the
feature/sdk-fetch-client
branch
from
3d104eb
to
9c7e9e2
Compare
matthieu-crouzet
approved these changes
Sep 17, 2024
fpaul-1A
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
move ApiFetchClient to dedicated package