Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GCP uploading #784

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Improve GCP uploading #784

merged 2 commits into from
Nov 19, 2023

Conversation

minguyen9988
Copy link
Contributor

@minguyen9988 minguyen9988 commented Nov 14, 2023

thanks Andrew W for the contribution.

The PR include 2 fix:

  • GCP upload need to return the error, currently it cannot catch upload error and retry, because the error is handle in defer and never return to caller, so it will fail at the first failure.
  • Add support for HTTP reverse proxy handling, if the flag force_http is set to true it will use http reverse proxy.

@aadant
Copy link

aadant commented Nov 17, 2023

@Slach do you mind reviewing this ?

@Slach
Copy link
Collaborator

Slach commented Nov 19, 2023

@minguyen9988 please renew cli snapshot

clear && rm -fv ./test/testflows/clickhouse_backup/tests/snapshots/cli.py.cli.snapshot && RUN_TESTS="/clickhouse backup/cli*" ./test/testflows/run.sh

@Slach Slach merged commit b212bda into Altinity:master Nov 19, 2023
5 of 18 checks passed
@minguyen9988
Copy link
Contributor Author

ok I will do it before the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants