Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe bash script example #716

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Update ReadMe bash script example #716

merged 1 commit into from
Aug 2, 2023

Conversation

0div
Copy link
Contributor

@0div 0div commented Aug 2, 2023

Thanks for your awesome tool! I noticed some things to update in your example bash script:

  • Calling $? twice in a row has the effect of not capturing the first exit code wanted for logging, it is best to assign it to a var and preserve it that way
  • also reusing the capture exit code to exit the script with it (using 2>&1)
  • redirecting stderr to the log file as well.

@Slach Slach merged commit 6eec986 into Altinity:master Aug 2, 2023
7 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants