Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object disk backup #702

Merged
merged 12 commits into from
Jul 24, 2023
Merged

Object disk backup #702

merged 12 commits into from
Jul 24, 2023

Conversation

Slach
Copy link
Collaborator

@Slach Slach commented Jul 24, 2023

Fix #447
require add object_disk_path config option to s3, gcs, azure section
currently supports s3->s3, gcs over s3->gcs, azure->azure

need measure performance for create / restore

Slach added 11 commits July 20, 2023 18:14
…ackoverflow.com/a/74382598/1204665, aws/aws-sdk-go-v2#1816, GCS over S3 have no 5Gb restriction, TestIntegrationGCS pass again, TestIntegrationEmbedded need to fix
… using embedded backup, cleanup integration_test.go move testBackupSpecifiedPartitions near runTestMainScenario, all tests passed 1400 seconds
…b actions

docker-compose requires PyYAML<6,>=3.10
which failed to install
```
 /tmp/pip-build-env-x3k7dqup/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
      !!

              ********************************************************************************
              The license_file parameter is deprecated, use license_files instead.

              By 2023-Oct-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.
```
@coveralls
Copy link

coveralls commented Jul 24, 2023

Pull Request Test Coverage Report for Build 5644456444

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 520 of 768 (67.71%) changed or added relevant lines in 15 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.6%) to 65.988%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/storage/general.go 1 2 50.0%
pkg/storage/gcs.go 19 23 82.61%
pkg/config/config.go 10 16 62.5%
pkg/storage/cos.go 0 6 0.0%
pkg/storage/ftp.go 0 6 0.0%
pkg/storage/sftp.go 0 6 0.0%
pkg/storage/object_disk/object_disk.go 51 59 86.44%
pkg/backup/create.go 53 77 68.83%
pkg/storage/azblob.go 59 83 71.08%
pkg/backup/restore.go 78 120 65.0%
Files with Coverage Reduction New Missed Lines %
pkg/storage/object_disk/object_disk.go 1 68.43%
pkg/backup/delete.go 2 60.87%
Totals Coverage Status
Change from base Build 5585606585: 0.6%
Covered Lines: 7225
Relevant Lines: 10949

💛 - Coveralls

@Slach Slach merged commit 5cdb486 into master Jul 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants