Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scrolling on the background of the waybar #3401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnMH
Copy link

@JohnMH JohnMH commented Jul 2, 2024

This patch allows user events for scrolling on the waybar itself, when the mouse is not over a module.

This experience made me hate GTK 3.0. There's some duplicate code as a result of this too, for checking scroll direction. Smooth scrolling is not handled at all for the bar itself.

This could potentially be done in a better way with the C API.

@JohnMH
Copy link
Author

JohnMH commented Jul 3, 2024

A cleaner way to do this would most likely be to split the code for scroll direction out into the util namespace.

@JohnMH
Copy link
Author

JohnMH commented Jul 26, 2024

Rebased to make this easier to merge.

This experience made me hate GTK 3.0. There's some duplicate code as a
result of this too, for checking scroll direction. Smooth scrolling is
not handled at all for the bar itself.

Signed-off-by: John M. Harris Jr. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant