display name fix for html

AgoraIO-Community · Oct 1, 2020 · dc52ea4 · dc52ea4
1 parent fe03a83
commit dc52ea4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/electron/index.html b/electron/index.html
@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
 
     <base href="./">
-    <title>Test</title>
+    <title><%= htmlWebpackPlugin.options.title %></title>
 </head>
 <body>
 <div id="react-app" style="

diff --git a/web/index.html b/web/index.html
@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
 
     <base href="/">
-    <title>Test</title>
+    <title><%= htmlWebpackPlugin.options.title %></title>
 </head>
 <body>
     <style>

diff --git a/webpack.commons.js b/webpack.commons.js
@@ -15,11 +15,13 @@ module.exports = {
   plugins: [
     // Using html webpack plugin to utilize our index.html
     new HtmlWebpackPlugin({
+      title: configVars['$config.displayName'],
       template: isElectron ? 'electron/index.html' : 'web/index.html',
     }),
-    isDevelopment && new ReactRefreshWebpackPlugin({
-      overlay: false,
-    }),
+    isDevelopment &&
+      new ReactRefreshWebpackPlugin({
+        overlay: false,
+      }),
   ].filter(Boolean),
   resolve: {
     alias: {