[SPIKE] Get Google Analytics data for Company pages #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 23, 2019
|
|
||
|
|
||
| def self.max_dimension_name_length(rows) | ||
| # rubocop:disable UncommunicativeVariableName |
There was a problem hiding this comment.
Lint/UnneededCopDisableDirective: Unnecessary disabling of UncommunicativeVariableName (unknown cop).
| date_ranges: [date_range_days_ago(30)]) | ||
|
|
||
| report_info = { view_id: ENV['SHF_GOOGLE_ANALYTICS_VIEW_ID'], | ||
| date_ranges: date_ranges, |
There was a problem hiding this comment.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
|
|
||
| # get the size of the widest string in the column | ||
| def self.col_max_size(array, column_index) | ||
| array.map { |row| row[column_index] ? row[column_index].to_s.size : 0 }.max # rubocop:disable DuplicateMethodCall |
There was a problem hiding this comment.
Lint/UnneededCopDisableDirective: Unnecessary disabling of DuplicateMethodCall (unknown cop).
| # column_separator<String>:: String to use at the end of each column. Default = " " (2 spaces) | ||
| # | ||
| # @return [String] - a String with the formatted table | ||
| def self.print_table(array, options = {}) # rubocop:disable MethodLength |
There was a problem hiding this comment.
Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/MethodLength.
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: get data from Google Analytics
PT URL: https://www.pivotaltracker.com/story/show/168116590
This is a spike/exploration of getting data from GoogleAnalytics for company pages.
I put theses classes under
.../servicesjust because (1) they're still in exploratory stage, and (2) I didn't spend any time thinking about where else they could/should go. (Probably the 'array of arrrays formatter' should be put into /lib)I just wanted to get the code working and up here so we could look at it..
Filter for getting the company pages:
dim_filter_company_pagesReady for review:
@Luleherll