Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Horizontal bar charts without minimum size not calculating height on initial render #434

Conversation

joao-m-santos
Copy link
Contributor

📝 Description

A bar chart with orientation: 'horizontal' and noMinSize: true was rendering with 0px height instead of the correct height based on bar height and count.

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

--

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Jun 20, 2024
@joao-m-santos joao-m-santos requested a review from a team as a code owner June 20, 2024 09:53
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit c586442
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/6673fc734fdaf500081a0c16
😎 Deploy Preview https://deploy-preview-434--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joao-m-santos joao-m-santos force-pushed the fix-horizontal-bar-chart-without-min-size-not-calculating-height branch from f867a3a to c586442 Compare June 20, 2024 09:54
@joao-m-santos joao-m-santos merged commit b9818ca into main Jun 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants