SRPanel: small optimisation to only call document.querySelector once (#…

…2895) * Small optimisation to only call document.querySelector once, rather than 3 times * Added changeset file
Adyen · Oct 11, 2024 · 154be9a · 154be9a
1 parent 683a570
commit 154be9a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/.changeset/quiet-masks-agree.md b/.changeset/quiet-masks-agree.md
@@ -0,0 +1,5 @@
+---
+'@adyen/adyen-web': patch
+---
+
+Small optimisation to only call document.querySelector once, rather than three times
diff --git a/packages/lib/src/core/Errors/SRPanel.tsx b/packages/lib/src/core/Errors/SRPanel.tsx
@@ -36,24 +36,29 @@ export class SRPanel extends BaseElement<SRPanelProps> {
 
     constructor(checkout: ICore, props?: SRPanelProps) {
         super(checkout, props);
+
         this.id = this.props.id;
         this.showPanel = process.env.NODE_ENV !== 'production' ? this.props.showPanel : false;
         this._enabled = false;
         this._moveFocus = this.props.moveFocus ?? true;
 
         if (this.props.enabled) {
             this._enabled = true;
-            if (document.querySelector(this.props.node)) {
+
+            const panelParent = document.querySelector(this.props.node);
+
+            if (panelParent) {
                 const preExistingSRPanel = document.getElementById(this.id);
                 if (preExistingSRPanel) {
-                    document.querySelector(this.props.node).removeChild(preExistingSRPanel);
+                    panelParent.removeChild(preExistingSRPanel);
                 }
 
                 this.srPanelContainer = document.createElement('div');
                 this.srPanelContainer.className = 'sr-panel-holder';
                 this.srPanelContainer.id = this.id;
 
-                document.querySelector(this.props.node).appendChild(this.srPanelContainer);
+                panelParent.appendChild(this.srPanelContainer);
+
                 this.mount(this.srPanelContainer);
             } else {
                 throw new Error('Component could not mount. Root node was not found.');