Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated features #532

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Remove deprecated features #532

merged 2 commits into from
Aug 4, 2023

Conversation

michaelpaul
Copy link
Contributor

@michaelpaul michaelpaul commented Aug 2, 2023 •
edited
Loading

Description

Cleanup before the next major release.

Breaking changes

  • Removed logging (and monolog) because that is an application level policy. Errors are still propagated via exceptions. See API logs and do your own field logging for endpoints not available in Customer Area yet.
  • Directory lookup service

@michaelpaul michaelpaul added the breaking change Introduces a breaking API change (correlating with MAJOR in Semantic Versioning) label Aug 2, 2023
@michaelpaul michaelpaul requested a review from a team as a code owner August 2, 2023 09:57
@michaelpaul michaelpaul enabled auto-merge (squash) August 2, 2023 10:54
@michaelpaul michaelpaul mentioned this pull request Aug 2, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

61.9% 61.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@michaelpaul michaelpaul merged commit f6cb7c2 into develop Aug 4, 2023
3 of 4 checks passed
@michaelpaul michaelpaul deleted the prerelease-cleanup branch August 4, 2023 12:27
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrosMor AlexandrosMor AlexandrosMor approved these changes

@candemiralp candemiralp candemiralp approved these changes

@wboereboom wboereboom wboereboom approved these changes

@jillingk jillingk jillingk approved these changes

Assignees
No one assigned
Labels
breaking change Introduces a breaking API change (correlating with MAJOR in Semantic Versioning)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelpaul @AlexandrosMor @candemiralp @wboereboom @jillingk