Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display toolbar on all intermediary screens for drop-in #1832

Open
wants to merge 2 commits into
base: feature/google-pay
Choose a base branch
from

Conversation

OscarSpruit
Copy link
Contributor

Description

Display toolbar in drop-in Google Pay fragment (all other fragments already have a toolbar). In a follow up PR we will show a loading indicator on all these intermediary screens as well.

Checklist

  • PR is labelled
  • Changes are tested manually

COAND-1012

@OscarSpruit OscarSpruit added the Fix [PRs only] Indicates a bug fix label Oct 15, 2024
@OscarSpruit OscarSpruit requested a review from a team as a code owner October 15, 2024 13:51
@@ -27,6 +27,7 @@
- For UPI Intent an error message will be shown when "Continue" button is pressed without selecting
any UPI option.
- For drop-in, improved accessibility of back/close button in the navigation bar.
- For drop-in, show a toolbar on every intermediary screen, so shoppers can always easily navigate back.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file still has the old release notes

Base automatically changed from feature/google-pay-button-styling to feature/google-pay October 15, 2024 15:20
@OscarSpruit OscarSpruit force-pushed the fix/intermediate-screen-toolbar branch from b29c195 to eba079c Compare October 15, 2024 15:20
Copy link

✅ No public API changes

Copy link

sonarcloud bot commented Oct 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix [PRs only] Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants