Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict CardNumberValidator.MAXIMUM_CARD_NUMBER_LENGTH to library group #1821

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Restrict CardNumberValidator.MAXIMUM_CARD_NUMBER_LENGTH to library group #1821

merged 1 commit into from
Oct 11, 2024

Conversation

ozgur00
Copy link
Contributor

@ozgur00 ozgur00 commented Oct 11, 2024

Description

Restrict public field CardNumberValidator.MAXIMUM_CARD_NUMBER_LENGTH to library group.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-985

@ozgur00 ozgur00 added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Oct 11, 2024
@ozgur00 ozgur00 requested a review from a team as a code owner October 11, 2024 13:36
@github-actions GitHub Actions
Copy link

✅ No public API changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ozgur00 ozgur00 merged commit c9fec23 into develop Oct 11, 2024
9 checks passed
@ozgur00 ozgur00 deleted the fix/card_number_validator_length_restricted branch October 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OscarSpruit OscarSpruit OscarSpruit approved these changes

Assignees
No one assigned
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozgur00 @OscarSpruit