-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose card input field validation functionality to public #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreij
reviewed
Oct 8, 2024
jreij
reviewed
Oct 8, 2024
jreij
reviewed
Oct 8, 2024
jreij
reviewed
Oct 8, 2024
checkout-core/src/main/java/com/adyen/checkout/core/ui/model/ExpiryDate.kt
Show resolved
Hide resolved
jreij
reviewed
Oct 8, 2024
checkout-core/src/main/java/com/adyen/checkout/core/ui/model/ExpiryDate.kt
Show resolved
Hide resolved
jreij
reviewed
Oct 8, 2024
checkout-core/src/main/java/com/adyen/checkout/core/ui/validation/CardExpiryDateValidator.kt
Outdated
Show resolved
Hide resolved
ozgur00
force-pushed
the
feature/public_validators
branch
from
October 8, 2024 14:19
fa648d5
to
4f46ad5
Compare
jreij
reviewed
Oct 8, 2024
...t-core/src/main/java/com/adyen/checkout/core/ui/validation/CardExpiryDateValidationResult.kt
Outdated
Show resolved
Hide resolved
jreij
reviewed
Oct 8, 2024
checkout-core/src/main/java/com/adyen/checkout/core/ui/validation/CardNumberValidationResult.kt
Outdated
Show resolved
Hide resolved
jreij
reviewed
Oct 9, 2024
...t-core/src/main/java/com/adyen/checkout/core/ui/validation/CardExpiryDateValidationResult.kt
Outdated
Show resolved
Hide resolved
jreij
reviewed
Oct 9, 2024
checkout-core/src/main/java/com/adyen/checkout/core/ui/validation/CardExpiryDateValidator.kt
Outdated
Show resolved
Hide resolved
ozgur00
force-pushed
the
feature/public_validators
branch
from
October 10, 2024 09:47
d03af2d
to
71a25db
Compare
COAND-985
…Validator COAND-985
COAND-985
Also update tests in CardValidationUtilsTest COAND-985
COAND-985
ozgur00
force-pushed
the
feature/public_validators
branch
from
October 10, 2024 09:51
71a25db
to
90d44ed
Compare
jreij
approved these changes
Oct 10, 2024
✅ No public API changes |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added public
CardNumberValidator
,CardExpiryDateValidator
andCardSecurityCodeValidator
classes to make our internal validation available for merchants.Checklist
COAND-985