Correctly check nullability when reading from JSON objects #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreij
force-pushed
the
fix/json-serialization
branch
from
1882a49
to
36ea4f2
Compare
ozgur00
reviewed
Oct 7, 2024
| @@ -20,22 +20,27 @@ private const val PARSING_ERROR = "PARSING_ERROR" | |||
|
|
|||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| fun JSONObject.getStringOrNull(key: String): String? { | |||
| return if (has(key)) getString(key) else null | |||
| return if (!isNull(key)) getString(key) else null | |||
There was a problem hiding this comment.
We don't have tests for these functions. Can we add some tests so we know if something gets broken in the future?
There was a problem hiding this comment.
We can indeed, the problem is that the bug we found cannot be reproduced in tests :/ I will add some anyway.
COAND-994
COAND-994
jreij
force-pushed
the
fix/json-serialization
branch
from
36ea4f2
to
6a29028
Compare
✅ No public API changes |
|
OscarSpruit
approved these changes
Oct 7, 2024
ozgur00
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
JSONObject.haswith!JSONObject.isNullwhen reading JSON values to ensure correct handling of null values.Checklist
COAND-994