Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics - Send failed checkoutAttemptId if fetching fails #1802

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Analytics - Send failed checkoutAttemptId if fetching fails #1802

merged 1 commit into from
Oct 7, 2024

Conversation

araratthehero
Copy link
Contributor

@araratthehero araratthehero commented Oct 3, 2024 •
edited
Loading

Description

  • If fetching checkoutAttemptId fails, we send fetch-checkoutAttemptId-failed for its value.
  • It should only be sent as part of /payments call, so we should stop sending analytics events if checkoutAttemptId has failed to fetch.

Checklist

  • Backend approved the change
  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-982

@araratthehero araratthehero added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Oct 3, 2024
@araratthehero araratthehero force-pushed the feature/analytics_send_failed_checkout_attempt_id branch from 7e58984 to 752362c Compare October 3, 2024 12:06
@araratthehero araratthehero marked this pull request as ready for review October 7, 2024 05:46
@araratthehero araratthehero requested a review from a team as a code owner October 7, 2024 05:46
@araratthehero araratthehero force-pushed the feature/analytics_send_failed_checkout_attempt_id branch from 2d5c0a4 to 54b13eb Compare October 7, 2024 07:48
@araratthehero araratthehero force-pushed the feature/analytics_send_failed_checkout_attempt_id branch from 54b13eb to acf647e Compare October 7, 2024 07:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

✅ No public API changes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@araratthehero araratthehero merged commit fcb7d8f into develop Oct 7, 2024
9 checks passed
@araratthehero araratthehero deleted the feature/analytics_send_failed_checkout_attempt_id branch October 7, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OscarSpruit OscarSpruit OscarSpruit approved these changes

Assignees
No one assigned
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@araratthehero @OscarSpruit