Analytics - Fix malformed locale in analytics setup request #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarSpruit
added
the
Chore
jreij
reviewed
Oct 2, 2024
...yen/checkout/components/core/internal/analytics/data/remote/DefaultAnalyticsSetupProvider.kt
Show resolved
Hide resolved
OscarSpruit
force-pushed
the
fix/malformed-locale
branch
from
984770e
to
0a9890e
Compare
jreij
approved these changes
Oct 4, 2024
araratthehero
changed the title
OscarSpruit
force-pushed
the
fix/malformed-locale
branch
from
0a9890e
to
b0784cd
Compare
✅ No public API changes |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix malformed locale in analytics setup request. The backend only accepts language tags (
xx-YY-zzzzzz) and not full unformatted locales (xx_YY_#zzzzzz).Checklist
COAND-993