-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French Meal Vouchers #1788
Merged
Merged
French Meal Vouchers #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreij
reviewed
Sep 10, 2024
ui-core/src/main/java/com/adyen/checkout/ui/core/internal/ui/view/ExpiryDateInput.kt
Outdated
Show resolved
Hide resolved
jreij
reviewed
Sep 10, 2024
ui-core/src/main/java/com/adyen/checkout/ui/core/internal/ui/view/SecurityCodeInput.kt
Outdated
Show resolved
Hide resolved
araratthehero
force-pushed
the
feature/french_meal_vouchers
branch
from
September 10, 2024 08:50
9b76d8b
to
f6c2f5e
Compare
jreij
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a method for this configuration inside DropInConfiguration.Builder
araratthehero
force-pushed
the
feature/french_meal_vouchers
branch
from
September 23, 2024 14:13
e32aada
to
8f27f85
Compare
COAND-683
COAND-683
…ext instead of CardNumberInput COAND-683
COAND-683
COAND-683
…CardValidator COAND-683
GiftCardProtocol is used to make and get necessary details for different Gift Card flows such as gift cards and meal vouchers. COAND-693
GiftCardProtocol is used to make and get necessary details for different Gift Card flows such as gift cards and meal vouchers. COAND-693
COAND-683
GiftCardProtocol is used to make and get necessary details for different Gift Card flows such as gift cards and meal vouchers. COAND-693
COAND-683
COAND-683
COAND-693
COAND-693
COAND-693
COAND-693
COAND-693
COAND-693
COAND-693
ozgur00
force-pushed
the
feature/french_meal_vouchers
branch
from
October 8, 2024 08:40
58a9da8
to
eab8242
Compare
jreij
reviewed
Oct 8, 2024
COAND-693
COAND-693
COAND-693
COAND-693
ozgur00
force-pushed
the
feature/french_meal_vouchers
branch
from
October 8, 2024 09:05
eab8242
to
0df176d
Compare
✅ No public API changes |
Quality Gate failedFailed conditions |
jreij
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of French meal vouchers.
The implementation extends the Giftcard logic, since French meal vouchers are handled like giftcards, with an additional field. To keep them separate, a new module has been created.
Pending
We are still waiting for test cards to finalize the testing of the integration.
Checklist
COAND-683