Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger #64

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

arihantbansal
Copy link
Contributor

This PR resolves Issue #23.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #64 (c6ba6f0) into main (191a0a9) will decrease coverage by 4.08%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##              main      #64      +/-   ##
===========================================
- Coverage   100.00%   95.91%   -4.09%     
===========================================
  Files           17       19       +2     
  Lines          704      734      +30     
===========================================
  Hits           704      704              
- Misses           0       30      +30     
Impacted Files Coverage Δ
code_soup/utils/__init__.py 0.00% <0.00%> (ø)
code_soup/utils/logger.py 0.00% <0.00%> (ø)

@someshsingh22 someshsingh22 self-requested a review August 28, 2021 09:44
Copy link
Member

@someshsingh22 someshsingh22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arihantbansal you have not added the callbacks, the logger needs to have that as well

Copy link
Member

@someshsingh22 someshsingh22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks extensive and great! However, since this is in the debug mode it is not being tested, If you can add an example to show the behavior of all Loggers

@someshsingh22 someshsingh22 linked an issue Aug 31, 2021 that may be closed by this pull request
3 tasks
@someshsingh22
Copy link
Member

@arihantbansal Can you try implementing your logger in the GAN Tutorial notebook so we can merge it ?

@someshsingh22 someshsingh22 self-requested a review October 11, 2021 01:00
@someshsingh22 someshsingh22 self-requested a review October 11, 2021 01:01
@someshsingh22
Copy link
Member

someshsingh22 commented Oct 11, 2021

@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR

@arihantbansal
Copy link
Contributor Author

@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR

I'll try fix the callback logging and implement it in the tutorial by EOD.
What are the requirements for the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common Utility Functions: Logging
2 participants