Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing a way to store SCP in experience fragments #2930

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Derthenier
Copy link
Contributor

Enabling shared component nodes in experience fragment folder structure

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #2930 (dce9a00) into master (ce3787a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2930   +/-   ##
=========================================
  Coverage     54.05%   54.05%           
  Complexity     5609     5609           
=========================================
  Files           756      756           
  Lines         30779    30779           
  Branches       3978     3978           
=========================================
  Hits          16637    16637           
  Misses        12594    12594           
  Partials       1548     1548           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davidjgonzalez
Copy link
Contributor

@Derthenier looks good - are there possibilities of conflicting w/ people that are already overlaying this space? Could we collide/overwrite with some else's customization?

@davidjgonzalez davidjgonzalez added this to the 5.3.4 milestone Aug 22, 2022
@davidjgonzalez davidjgonzalez removed this from the 5.3.4 milestone Aug 22, 2022
@Derthenier
Copy link
Contributor Author

It is possible that it will create conflicts for people extending the experience fragments

@davidjgonzalez
Copy link
Contributor

I wonder if we just package this up and link to it from the docs page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants