feat: add pre check for rate limit

[yjhmelody]

The outer result of until_key_n_ready_with_jitter should be checked before start service, it's static result relatively .
And its meaning is the cap is insufficient for n.

[ermalkaleci]

if you want to check this then just make sure no weight is greater than burst (ip or connection)

[yjhmelody]

Yeah, The result is fixed if config is not changed, so we should do pre-check.
Oherwise how do we know the config is correct.

[ermalkaleci]

you can simple verify config file

[yjhmelody]

you can simple verify config file

This code is doing what you said.

[ermalkaleci]

you can simple verify config file

This code is doing what you said.

no it's not. you're adding additional code that needs to be maintained and no necessary at all.
All you need to do is validate config file. assert!(method.rate_limit_weight <= min(ip.burst, connection.burst))

[ermalkaleci]

it can be done here https://github.com/AcalaNetwork/subway/blob/ac19fefb38a001a30c59922ad7a33b6f9cd2cdd7/src/config/mod.rs#L206C14-L206C22

[yjhmelody]

That's not true, you just assumed period_secs ==1s.

You could try run this branch and master branch, it do need extra check.

Wait, maybe we just need to move this validation logic to there. But we still need such check logic.

Now:

./target/release/subway --config ./configs/config.yml
2024-06-24T10:16:38.652904Z ERROR subway: Config validation failed: `author_pendingExtrinsics` weight config too big for ip rate limit: 10000
2024-06-24T10:16:38.654024Z  INFO subway::extensions::client: Connecting to endpoint: wss://acala-rpc-0.aca-api.network
2024-06-24T10:16:38.655018Z  INFO substrate_prometheus_endpoint: 〽️ Prometheus exporter started at 0.0.0.0:9616    
2024-06-24T10:16:38.655339Z  INFO subway: Server running at 0.0.0.0:9944
2024-06-24T10:16:39.320293Z  INFO subway::extensions::client: Endpoint connected

[yjhmelody]

Wonder the behavior design: why still continue the service when validation failed.

[ermalkaleci]

because it runs on it's own thread. it should work for any period

[xlc]

some tests will be nice

[ermalkaleci]

All you need to do is validate config file. assert!(method.rate_limit_weight <= min(ip.burst, connection.burst))

@xlc @yjhmelody In case you missed this

[yjhmelody]

All you need to do is validate config file. assert!(method.rate_limit_weight <= min(ip.burst, connection.burst))

@xlc @yjhmelody In case you missed this

Hi, you are right, I have simplify the code.