validate middleware #156
Merged
validate middleware #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Apr 11, 2024
xlc
reviewed
Apr 12, 2024
|
|
||
| pub fn validate(&self, client: Arc<Client>, request: CallRequest, response: CallResult) { | ||
| tokio::spawn(async move { | ||
| let healthy_endpoints = client.endpoints().iter().filter(|x| x.health().score() > 0); |
There was a problem hiding this comment.
should we have a helper method healthy_endpoints?
There was a problem hiding this comment.
yeah makes sense
| pub fn validate(&self, client: Arc<Client>, request: CallRequest, response: CallResult) { | ||
| tokio::spawn(async move { | ||
| let healthy_endpoints = client.endpoints().iter().filter(|x| x.health().score() > 0); | ||
| futures::future::join_all(healthy_endpoints.map(|endpoint| async { |
There was a problem hiding this comment.
do we need to filter out the current endpoint?
There was a problem hiding this comment.
response may come from cache, so why not hit them all
xlc
approved these changes
Apr 15, 2024
|
maybe have an example config file |
|
I think it's easy to copy/paste config from README and make use of validator |
kostekIV
added a commit
to Cardinal-Cryptography/subway
that referenced
this pull request
Apr 29, 2024
* subsquid indexer & processor fix (AcalaNetwork#150) * update deps (AcalaNetwork#155) * bypass cache for unfinalized blocks (AcalaNetwork#154) * endpoint health (AcalaNetwork#152) * Await healthy endpoint (AcalaNetwork#158) * use only tracing (AcalaNetwork#157) * Filter call errors (AcalaNetwork#159) * validate middleware (AcalaNetwork#156) * validate middleware * validate extension for config * rename * Improve env handling via preprocessing templated config files (AcalaNetwork#162) * Feat(config): support ${var:-word} and ${var:+word} syntax (AcalaNetwork#164) * fix cli default value (AcalaNetwork#169) * improve reconnect wait time (AcalaNetwork#168) --------- Co-authored-by: mrq1911 <[email protected]> Co-authored-by: Ermal Kaleci <[email protected]> Co-authored-by: Jiyuan Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #75