record error on span::error (#140)

AcalaNetwork · Nov 21, 2023 · d534226 · d534226
1 parent b732b66
commit d534226
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/extensions/client/mod.rs b/src/extensions/client/mod.rs
@@ -399,6 +399,7 @@ impl Client {
                 }
                 Err(err) => {
                     span.set_status(opentelemetry::trace::Status::error(err.to_string()));
+                    span.record_error(&err);
                 }
             });
 
@@ -434,9 +435,8 @@ impl Client {
                     span.set_status(opentelemetry::trace::Status::Ok);
                 }
                 Err(err) => {
-                    span.set_status(opentelemetry::trace::Status::Error {
-                        description: std::borrow::Cow::from(err.to_string()),
-                    });
+                    span.set_status(opentelemetry::trace::Status::error(err.to_string()));
+                    span.record_error(&err);
                 }
             });
 

diff --git a/src/middlewares/mod.rs b/src/middlewares/mod.rs
@@ -156,6 +156,7 @@ impl<Request: Debug + Send + 'static, Result: Send + 'static> Middlewares<Reques
                 tracing::error!("middlewares timeout: {req}");
                 opentelemetry::trace::get_active_span(|span| {
                     span.set_status(opentelemetry::trace::Status::error("middlewares timeout"));
+                    span.record_error(&jsonrpsee::core::Error::Custom("middlewares timeout".to_string()));
                 });
                 task_handle.abort();
             }

diff --git a/src/server.rs b/src/server.rs
@@ -98,6 +98,7 @@ pub async fn build(config: Config) -> anyhow::Result<SubwayServerHandle> {
                             }
                             Err(err) => {
                                 span.set_status(opentelemetry::trace::Status::error(err.to_string()));
+                                span.record_error(&err);
                             }
                         });
 
@@ -168,6 +169,7 @@ pub async fn build(config: Config) -> anyhow::Result<SubwayServerHandle> {
                                 }
                                 Err(err) => {
                                     span.set_status(opentelemetry::trace::Status::error(format!("{:?}", err)));
+                                    span.record_error(&jsonrpsee::core::Error::Custom(format!("{:?}", err)));
                                 }
                             });