Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order pip requirements when converting to keep a constant hash #1829

Conversation

samson-jerome
Copy link
Contributor

When using rez pip, the order of requirements collected from distributions may vary. This eventually changes the variants hash generated which leads to reinstalling a package already installed (with a different hash but identical requirements).

closes: #1414

@samson-jerome samson-jerome requested a review from a team as a code owner September 20, 2024 10:16
Copy link

CLA Missing ID CLA Not Signed

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.52%. Comparing base (41fb213) to head (cdf4bc7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/utils/pip.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1829   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         126      126           
  Lines       17206    17206           
  Branches     3519     3519           
=======================================
  Hits        10069    10069           
  Misses       6468     6468           
  Partials      669      669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samson-jerome
Copy link
Contributor Author

I'm in the process of having the CLA signed for our studio...

@samson-jerome
Copy link
Contributor Author

Can't get quick EasyCLA approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rez-pip does not create variants with a consistent order, potentially causing duplicates.
1 participant