Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing path in GitBash warning message #1775

Conversation

brycegbrazen
Copy link
Contributor

When testing out Gitbash, I noticed there was a print that was not being formatted. This fixes the issue.

@brycegbrazen brycegbrazen requested a review from a team as a code owner June 20, 2024 16:42
@brycegbrazen brycegbrazen force-pushed the gitbash_executable_output_fix branch from 04de845 to 2920ca5 Compare June 20, 2024 16:43
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.41%. Comparing base (a13f7bb) to head (2920ca5).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1775   +/-   ##
=======================================
  Coverage   58.41%   58.41%           
=======================================
  Files         126      126           
  Lines       17163    17163           
  Branches     3506     3506           
=======================================
  Hits        10025    10025           
  Misses       6473     6473           
  Partials      665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brycegbrazen
Copy link
Contributor Author

I see this is also fixed in #1475. Might just be worth waiting for that one as they fixed it a bit differently.

@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Gitbash Executable Output Fix Fix missing path in GitBash warning message Jun 22, 2024
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 271ba34 into AcademySoftwareFoundation:main Jun 22, 2024
47 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Jun 22, 2024
Pixel-Minions added a commit to Pixel-Minions/rez that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants