Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to cache package payloads synchronously #1679

Merged
merged 20 commits into from
Jun 29, 2024
Merged

Add ability to cache package payloads synchronously #1679

merged 20 commits into from
Jun 29, 2024

Commits on Mar 6, 2024

  1. Add package_cache_async flag. 

    Adds a `package_cachy_async` flag which allows users to run caching synchronously (blocking) or asynchronously from the config.

Signed-off-by: ttrently <[email protected]>
    @ttrently @isohedronpipeline
    ttrently authored and isohedronpipeline committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0d1e29c View commit details
    Browse the repository at this point in the history

  2. Change _async to default True 

    Change _async to default True instead of False to mimic previous behavior.

Signed-off-by: ttrently <[email protected]>
    @ttrently @isohedronpipeline
    ttrently authored and isohedronpipeline committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d6ede1b View commit details
    Browse the repository at this point in the history

  3. Rename add_variants_async to add_variants 

    Renamed `add_variants_async` to `add_variants` as this method can now run with an `_async` flag.

Signed-off-by: ttrently <[email protected]>
    @ttrently @isohedronpipeline
    ttrently authored and isohedronpipeline committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    98bd61f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. added test cases and rez env flag 

    Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9463a3b View commit details
    Browse the repository at this point in the history

  2. flake8 fix 

    Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5a55f51 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline @JeanChristopheMorinPerso
    isohedronpipeline and JeanChristopheMorinPerso authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5ea2576 View commit details
    Browse the repository at this point in the history

  2. Addressed some feedback 

    Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2251de8 View commit details
    Browse the repository at this point in the history

  3. Add deprecated directive for add_variants_async 

    Signed-off-by: Jean-Christophe Morin <[email protected]>
    @JeanChristopheMorinPerso
    JeanChristopheMorinPerso authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b0309eb View commit details
    Browse the repository at this point in the history

  4. Fix versionadded version 

    Signed-off-by: Jean-Christophe Morin <[email protected]>
    @JeanChristopheMorinPerso
    JeanChristopheMorinPerso authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2bb1ce6 View commit details
    Browse the repository at this point in the history

  5. Updated rez env argument description for package-cache-mode 

    Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b5950d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. sync mode no longer subprocesses a daemon mode 

    Reports progress while waiting for another package to finish copying

Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    461adb1 View commit details
    Browse the repository at this point in the history

  2. line length fix 

    Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2253d76 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Cache reports variant.qualified_name and removed _print_with_spinner() 

    Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1c6c94b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Update src/rez/package_cache.py 

    Co-authored-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline @JeanChristopheMorinPerso
    isohedronpipeline and JeanChristopheMorinPerso authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a5997b9 View commit details
    Browse the repository at this point in the history

  2. Update src/rez/package_cache.py 

    Co-authored-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline @JeanChristopheMorinPerso
    isohedronpipeline and JeanChristopheMorinPerso authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d8dbe4e View commit details
    Browse the repository at this point in the history

  3. Made run_caching_operation private 

    changed wait_for_copying on run_caching_operation default to True
Signed-off-by: Ben Andersen <[email protected]>
    @isohedronpipeline
    isohedronpipeline committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    72747ca View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Remove redundant else 

    Signed-off-by: Jean-Christophe Morin <[email protected]>
    @JeanChristopheMorinPerso
    JeanChristopheMorinPerso committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    a8d0439 View commit details
    Browse the repository at this point in the history

  2. Fix flake8 warning 

    Signed-off-by: Jean-Christophe Morin <[email protected]>
    @JeanChristopheMorinPerso
    JeanChristopheMorinPerso committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    71e0c4a View commit details
    Browse the repository at this point in the history

  3. More flake8 warnings fix 

    Signed-off-by: Jean-Christophe Morin <[email protected]>
    @JeanChristopheMorinPerso
    JeanChristopheMorinPerso committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b12651e View commit details
    Browse the repository at this point in the history

  4. Adjust versions to 3.2.0 

    Signed-off-by: Jean-Christophe Morin <[email protected]>
    @JeanChristopheMorinPerso
    JeanChristopheMorinPerso committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    355a891 View commit details
    Browse the repository at this point in the history