Feature/prop bytes #161
Merged
Feature/prop bytes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Miller <[email protected]>
Signed-off-by: Paul Miller <[email protected]>
Signed-off-by: Paul Miller <[email protected]>
revisionfx
reviewed
May 9, 2024
There was a problem hiding this comment.
Happy to Approve - just a simple question.
I forget how is the doc get updated so it's added to this list (pasted below)
There should maybe be a mention that this is exclusively assume constant step animation and the KF suite is used to find nearest ones if more than one... - also does an host expect the length to be constant for all frames (aside when null on a frame)?
By default the following parameter types animate…
revisionfx
previously approved these changes
May 13, 2024
|
I updated the custom example plugin code to correctly check for Bytes support and also added a test for correct handling of really large data (10MB). |
garyo
approved these changes
Jul 12, 2024
|
Ideally we should add C++ support, but this is good enough for the spec change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the new Bytes property type to the ofxParam.h header, and adds sample code to the existing example for the Custom parameter type.
Feature Issue #145