Add RV as a participant using the new Live Review schema #602
Conversation
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
eloisebrosseau
changed the title
eloisebrosseau
force-pushed
the
live-review
branch
2 times, most recently
from
69eda0b
to
cc45e67
Compare
|
|
||
|
|
||
| @otio.core.register_type | ||
| class Annotation(otio.schema.Effect): |
There was a problem hiding this comment.
This is not specific to you, we've already gone down this road in the past, but I am mentioning it here because we might want to consider doing this a different way.
The problem with inheriting from Effect instead of just using Effect directly (and relying on the effect_name to know what the effect is) is that it prevents applications that don't have the schema from reading the OTIO. They will error out with an Unknown schema error.
It might be something fixable on the OTIO-side as well, but for now this problem still occurs, and it not necessarily the standard way of dealing with effects.
| otio_obj = otio.adapters.read_from_string(otio_string) | ||
| timeline = otio_obj["otio"] | ||
|
|
||
| if host_prefix is not None: |
There was a problem hiding this comment.
Simpler way of doing that:
context = {"sg_url": host_prefix} if host_prefix else None
There was a problem hiding this comment.
You're right, thanks!
| @@ -276,12 +294,12 @@ def _create_track(in_seq, context=None): | |||
| return new_seq | |||
|
|
|||
|
|
|||
| def _get_global_transform(tl): | |||
| def _get_global_transform(tl) -> dict: | |||
There was a problem hiding this comment.
Great, thanks for adding these.
eloisebrosseau
force-pushed
the
live-review
branch
from
cc45e67
to
e5d92be
Compare
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
live-review
branch
from
e5d92be
to
428d9e5
Compare
Add RV as a participant using the new Live Review schema
Summarize your change.
The
read_otio_stringfunction was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage.Describe the reason for the change.
This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App.
Describe what you have tested and on which operating system.
Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS.