Default sequences replaced when comparing media from FPTR #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chxmberland
requested review from
bernie-laberge,
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
### Linked issues N/A Based on this review: AcademySoftwareFoundation#530 (comment) ### Summarize your change. Include statement in `src/lib/app/TwkApp/Bundle.cpp` has been fixed. ### Describe the reason for the change. The include statement was trying to include a file that dosen't exist, `file.h` instead of `File.h`. ### Describe what you have tested and on which operating system. Builds correctly on... - MacOS 14.5 Sonoma Signed-off-by: Ben Chamberland <[email protected]>
…tically Signed-off-by: Ben Chamberland <[email protected]>
chxmberland
force-pushed
the
fix/default-sequence-replaced-by-comparison_SG-31769
branch
from
fa64748
to
ed5819c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
N/A
Summarize your change.
This When a user opens media from Flow Production Tracking, and then compares it to another piece of media in Flow Production Tracking, the default sequences are overwritten. Meaning, the user can no longer access the clips that they initially opened from FPTR. This can interrupt workflows.
If this change is implemented, along with another PR into OpenRV, users will have the option to enable a parameter in
Flow Production Tracking / Session Prefsthat will prevent this from happening.This PR, paired with a PR in Commercial RV, will resolve this issue. The changes made in this PR include a command that modifies a global preference to prevent media from being overwritten while comparing media.
Describe the reason for the change.
User wanted to be able to compare media without overwriting the original media.
Describe what you have tested and on which operating system.
MacOS 14.5 Sonoma