Allow users to paste text into the annotations tool #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chxmberland
requested review from
bernie-laberge,
rogernelson and
geffrak
as code owners
chxmberland
force-pushed
the
feature/add-mandarin-to-annotate_SG-35904
branch
from
2b8b663
to
c1b6346
Compare
|
This is great @chxmberland ! |
geffrak
reviewed
Jul 30, 2024
Signed-off-by: Ben Chamberland <[email protected]>
Signed-off-by: Ben Chamberland <[email protected]>
Signed-off-by: Ben Chamberland <[email protected]>
Signed-off-by: Ben Chamberland <[email protected]>
Signed-off-by: Ben Chamberland <[email protected]>
chxmberland
force-pushed
the
feature/add-mandarin-to-annotate_SG-35904
branch
from
d416dca
to
0230f6f
Compare
bernie-laberge
approved these changes
Aug 12, 2024
chxmberland
requested review from
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
cedrik-fuoco-adsk
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
N/A
Summarize your change.
This change will allow users to paste text when annotating using
ctrl + v.Describe the reason for the change.
This change was made in an effort to allow users to paste in East Asian languages into their annotations, which is a feature that has been requested for a very long time. Since it is far too complicated to directly support East Asian languages through keyboard inputs, this is the next best thing.
This PR is paired with PR #518 and will only be effective after PR #518 has been merged.
Describe what you have tested and on which operating system.
Tested in macOS Sonoma 14.5.
This must be tested in Windows and Linux, as the way you interact with clipboards changes across operating systems.