Fix iridas cube parser to accept and convert double precision. #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old Iridas cube parser would silently convert double precision values to floats and continue working, wheras the current code will raise an "Invalid color triplets" error. This patch restores the older behaviour. Signed-off-by: Shootfast <[email protected]>
The committers listed above are authorized under a signed CLA. |
remia
reviewed
Sep 24, 2024
| // Use doubles here as some iridas cube files may be written with double precision | ||
| // string values, and these will raise result_out_of_range errors in NumberUtils::from_chars | ||
| // instead of silently converting to float like they used to | ||
| double r = NAN; |
There was a problem hiding this comment.
It probably needs an explicit cast to double to make the Windows checks happy?
|
Actually I've just noticed this problem extends to other lut file formats as well - at least spi1d/spi3d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old Iridas cube parser would silently convert double precision values to floats and continue working, wheras the current code will raise an "Invalid color triplets" error.
This patch restores the older behaviour.