Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport OpenPBR Surface to MaterialX 1.38.10 #2082

Open
wants to merge 8 commits into
base: legacy_1.38
Choose a base branch
from

Conversation

JGamache-autodesk
Copy link
Contributor

Backports only the minimal code necessary to render native OpenPBR surface in MaterialX in a way that has no visual impact on the existing shaders and pbr nodes present in 1.38.

Status:

  • GLSL -> Fully functional
  • MSL -> Fully functional. Required only backporting the inversesqrt fix on top of the GLSL code.
  • OSL -> As functional as the 1.39 branch. Getting it fully functional requires OSL v1.14 features not yet released like Zeltner fuzz and compensating OrenNayar. I was not able to find any mention of a 82 deg color update on the OSL Schlick node though.
  • MDL -> Compiles and validates, but no updated visuals until an updated MDL library is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants