Add Shift + C hotkey to create a nodegraph from selected nodes #2048
Conversation
|
|
|
@WaffleBoyTom This looks like a great start, and to resolve the EasyCLA issue, I'd recommend following up through the support link that the Linux Foundation provides: https://jira.linuxfoundation.org/servicedesk/customer/portal/4 |
|
In parallel with the CLA process, I'm CC'ing @lfl-eholthouser for her thoughts on the implementation of the feature. |
| if (ImGui::IsKeyReleased(ImGuiKey_C) && | ||
| io2.KeyShift && | ||
| !io2.KeyCtrl) | ||
| { |
There was a problem hiding this comment.
Can you put in a check to see if you're not already in a nodegraph as creating nodegraphs nested inside of nodegraphs is currently disallowed in the UI.
There was a problem hiding this comment.
I'll fix all of these issues ! Thanks :)
| !io2.KeyCtrl) | ||
| { | ||
| // cut nodes | ||
| if (!readOnly()) |
There was a problem hiding this comment.
It might be good to move this up to the above if condition instead of checking in multiple places. e.g. the nodegraph add is missing this check so can create a nodegraph under a read-only nodegraph.
|
|
||
| if (_currUiNode != nullptr) | ||
| { | ||
| if (_currUiNode->getNode() != nullptr) |
There was a problem hiding this comment.
I assume only 1 of these 2 if / else paths will be taken and uou can remove the other cases logic.
I'm guessing it's the else path that is used ?
| { | ||
| _popup = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
You probably want to do a check if there are any items in _copiedNodes. If it's empty I think you'll end up creating an empty nodegraph with the current logic.
|
I wanted to follow up on this proposal, @WaffleBoyTom, to see if you might have the bandwidth to address the requests above. Let us know either way! |
Addresses #2018.
Shift + C will create nodegraph containing selected nodes.
Connections are not preserved.