Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image substitution #66

Merged
merged 13 commits into from
Jun 1, 2024

Conversation

oniboni
Copy link
Collaborator

@oniboni oniboni commented May 18, 2024

  • replace markdown with html in on_page_markdown, bc it does not get reevaluated inside of inline html
  • try out the object tag
  • (optional) add selenium tests to compare the layout

Closes: #35, #61

@oniboni oniboni linked an issue May 18, 2024 that may be closed by this pull request
@oniboni oniboni marked this pull request as ready for review June 1, 2024 10:44
@oniboni oniboni merged commit 6405d54 into main Jun 1, 2024
5 checks passed
@jonesbusy
Copy link

Thanks. It works great with mkdocs-material.

But apparently it break rendering on Backstage (https://github.com/backstage/backstage) in both preview and recommended deployment approach https://backstage.io/docs/features/techdocs/how-to-guides/#how-to-add-mermaid-support-in-techdocs

I will try to give more detail later today

@colinodell
Copy link

But apparently it break rendering on Backstage

Backstage explicitly forbids the use of <object> elements due to GHSA-gg96-f8wr-p89f. See also https://backstage.io/docs/features/techdocs/troubleshooting#plantuml-with-svg_object-doesnt-render

@jonesbusy
Copy link

The issue is #70

Well...

@oniboni Can it be svg inline instead of object (https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin/pull/66/files#diff-3f0b1dfd4eaf4f071c1adf4d665fff5854020c6dfcf87210551af489a1b298b7R29) ? We font should also load when <svg is rendered inline instead of via src

Thanks

@oniboni oniboni deleted the 61-image-does-not-render-when-inside-html-tags branch July 31, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Image does not render when inside HTML tags SVGs images are embaded as <img> -> they loose the fonts
3 participants